Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings) align password screen with design #13981

Merged
merged 2 commits into from
Mar 15, 2024
Merged

fix(settings) align password screen with design #13981

merged 2 commits into from
Mar 15, 2024

Conversation

stefandunca
Copy link
Contributor

@stefandunca stefandunca commented Mar 14, 2024 •
edited
Loading

Closes #13893

Required changes:

  • Fixed text colors
  • Fixed text expressions
  • Added dividers
  • Added labels
Design Implementation
image image

@status-im-auto
Copy link
Member

status-im-auto commented Mar 14, 2024 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5985fcb #1 2024-03-14 19:49:17 ~6 min macos/aarch64 🍎dmg
✔️ 5985fcb #1 2024-03-14 19:49:22 ~6 min tests/nim 📄log
✔️ 5985fcb #1 2024-03-14 19:54:00 ~11 min tests/ui 📄log
✔️ 5985fcb #1 2024-03-14 19:55:27 ~12 min macos/x86_64 🍎dmg
✔️ 5985fcb #1 2024-03-14 19:59:54 ~17 min linux/x86_64 📦tgz
✔️ 5985fcb #1 2024-03-14 20:13:33 ~30 min windows/x86_64 💿exe
✔️ 0892693 #2 2024-03-15 12:28:47 ~5 min macos/aarch64 🍎dmg
✔️ 0892693 #2 2024-03-15 12:29:15 ~5 min tests/nim 📄log
✔️ 0892693 #2 2024-03-15 12:30:56 ~7 min macos/x86_64 🍎dmg
✔️ 0892693 #2 2024-03-15 12:34:10 ~10 min tests/ui 📄log
✔️ 0892693 #2 2024-03-15 12:37:37 ~14 min linux/x86_64 📦tgz
✔️ 0892693 #2 2024-03-15 12:51:58 ~28 min windows/x86_64 💿exe

caybro
caybro approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefandunca
chore(storybook): add ChangePasswordView storybook page
73f6444 
Updates: #13893
@stefandunca
chore(settings) align password screen with design
0892693 
Changes required:

- Fixed text colors
- Fixed text expressions
- Added dividers
- Added labels

Closes #13893
@stefandunca stefandunca force-pushed the password_screen_aligned_with_design-13893 branch from 5985fcb to 0892693 Compare March 15, 2024 12:22
@stefandunca stefandunca mentioned this pull request Mar 15, 2024
Merged
1 task
@stefandunca stefandunca merged commit 086180b into master Mar 15, 2024
8 checks passed
@stefandunca stefandunca deleted the password_screen_aligned_with_design-13893 branch March 15, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaibe alaibe alaibe approved these changes

@caybro caybro caybro approved these changes

@alexandraB99 alexandraB99 Awaiting requested review from alexandraB99

@noeliaSD noeliaSD Awaiting requested review from noeliaSD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Password settings flow]Make the password screen looks exactly like design
4 participants
@stefandunca @status-im-auto @alaibe @caybro